Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chef bio optional #55

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Make chef bio optional #55

merged 1 commit into from
Aug 12, 2024

Conversation

jonathonherbert
Copy link
Contributor

What does this change?

Makes the chef bio optional. We'll want to pull in bio information from the tag page directly (as with images) in the curation lambda if there are no overrides.

How to test

In Fronts CODE with guardian/facia-tool#1612 deployed, add a chef to an issue, and publish. You should see the publish request succeed:

Screenshot 2024-08-02 at 14 40 25

Previous requests would fail with a Zod error (example logs.)

Copy link
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven’t tested in CODE, but this looks fine.

@jonathonherbert jonathonherbert merged commit 39c1d66 into main Aug 12, 2024
3 checks passed
@jonathonherbert jonathonherbert deleted the jsh/optional-chef-bio branch August 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants