Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client (and maybe model?) generated duplicate argument params if named same #1642

Closed
er1c opened this issue Nov 23, 2022 · 1 comment · Fixed by #1906
Closed

Client (and maybe model?) generated duplicate argument params if named same #1642

er1c opened this issue Nov 23, 2022 · 1 comment · Fixed by #1906

Comments

@er1c
Copy link

er1c commented Nov 23, 2022

Here's a base component:

image

We have two different types (Supply and Demand) and have unique descriptions:

image

The case class that gets generated has two productType instances:

case class SupplySubAccountUpdateData(
  name: String,
  displayName: String,
  description: Option[String] = None,
  disclaimer: Option[String] = None,
  imageUrl: Option[String] = None,
  notes: Option[String] = None,
  productType: Option[String] = None,
  subtextOverride: Option[String] = None, 
  integrationType: Option[SupplySubAccountIntegrationType] = None,
  dataShare: Option[String] = None,
  coBrand: Option[Boolean] = None,
  productType: Option[String] = None,
  subAccountOwners: Option[_root_.scala.Vector[SupplySubAccountOwnerCreateData]] = None
)
blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this issue Dec 26, 2023
blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this issue Dec 26, 2023
blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this issue Dec 26, 2023
blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this issue Dec 26, 2023
blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this issue Dec 26, 2023
blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this issue Dec 26, 2023
@blast-hardcheese
Copy link
Member

Hey there, sorry for the radio silence on this issue, thanks for the report. As I'm pushing towards a 1.0 release, I'm trying to resolve some of these low-hanging issues.

@blast-hardcheese blast-hardcheese linked a pull request Dec 26, 2023 that will close this issue
blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this issue Dec 26, 2023
blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this issue Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants