Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct protocol parameters #1906

Merged
merged 5 commits into from
Dec 26, 2023

Conversation

blast-hardcheese
Copy link
Member

@blast-hardcheese blast-hardcheese commented Dec 26, 2023

Resolves #1642

For generated DTOs, ensure parameters are deduplicated. Required parameters take priority over optional ones in the case of conflicts where the base types are the same.

@blast-hardcheese blast-hardcheese added bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past minor Bump minor version labels Dec 26, 2023
@blast-hardcheese blast-hardcheese merged commit 10eb849 into guardrail-dev:master Dec 26, 2023
28 checks passed
@blast-hardcheese blast-hardcheese deleted the resolve-1642 branch December 26, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past minor Bump minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client (and maybe model?) generated duplicate argument params if named same
1 participant