Clipping broke (see Clipping scenario) #2350
Labels
Comments
BDisp
added a commit
to BDisp/Terminal.Gui
that referenced
this issue
Feb 18, 2023
|
@tig I already fixed this. Thanks. |
tig
added a commit
that referenced
this issue
Feb 21, 2023
#2372) * Illustrates #2331 (Scrollview not respecting clip) does not reproduce (#2332) * Proves that the issue #2331 don't have reason to happen. * fixes #2336 * Fixes #2331. ScrollView may not be honoring clip region; CustomButton shows outside * More appropriate solution for the issue #2331. * Start refactoring LineCanvas for mixing line style support (e.g. double into single) * Add remaining resolvers * Implement corner border style mixing in LineCanvas * Refactor and simplify resolvers * Move tests to Core folder and namespace to Terminal.Gui.CoreTests * Fixes #2333. TextField is selecting badly a word on double click. * Add unit test deleting a word with accented char. * Fixes 2331. ScrollView may not be honoring clip region. * Add a custom button scenario. * Fixes #2350. Clipping broke (see Clipping scenario). * Is preferable use NeedDisplay instead of Bounds. --------- Co-authored-by: Tig Kindel <tig@users.noreply.github.com> Co-authored-by: tznind <tznind@dundee.ac.uk> * Fixes ASCIICustomButton scenario. * Adds Snake Scenario (#2353) * Add empty snake scenario * Move snake head around * Snake now has a tail * Rest of logic implementation * Ctrl K D layout fixes * Game gets faster as you collect more apples * Adjust speed increase rate down * Use white on black for snake and border and red for apple * Fix ScenarioTests not Disposing Scenario * Add disposes and fix to use LineCanvas.GenerateImage * Fix stack overflow, doh! --------- Co-authored-by: Tig <tig@users.noreply.github.com> * Fixes 2368. Nested views with height of 1 not rendering correctly. --------- Co-authored-by: Tig Kindel <tig@users.noreply.github.com> Co-authored-by: tznind <tznind@dundee.ac.uk> Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@BDisp you are the guru of clipping. Did you see that the Clipping scenario is not clipping correctly?
I don't remember the last time I tried it, and the clipping unit tests are working. So this is weird. Am I missing/forgetting something?
Note, I added a Text value to each of the 3 sub-windows to see if it was related to the TextFormatter codepath, but it didn't change the bad clip behavior.
The text was updated successfully, but these errors were encountered: