-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit requireFail color and message #142
Comments
@phated I am really impressed by how close you are to the |
We might also want to change this to a |
I'm allergic to the color red because it gets passed through to my docker build. It is not a failure, just attention grabbing. Just as a note, npm warnings about "EINTEGRITY" come through as 'red' too in a docker build. And what I mean by that is |
@sttk I just realized this issue wasn't fully completed by my PR. We still need to change the wording of the messages. I also think a "beforeRequire" event in liftoff would help improve messaging. Thoughts? |
@njnygaard I'm guessing you don't know of our --no-color flag? |
Why are we logging this message at all if it ends up working? |
@contra some of the logs happen in realtime (require logged right after it's required or fails) while some is batched but we don't know which is which. Also, I think there was a desire to show the user when they were using an older loader (e.g. |
Yes, I remember that there is a request to add the event to liftoff (gulpjs/liftoff#53). I agree it, and I'll address it if I can. |
This message has caused some trouble with some CI servers for us, just bailing out on the build due to red or the words We could just update the babel setup, but don't feel like updating to |
This was closed by #182 because it pulled in Liftoff 3.1, and v3 removed the extra logging if we found 1 successful loader. It should be released very soon. |
It seems that some consumers are allergic to the color red - we should revisit the coloring and messaging of the
requireFail
log.Ref foundation/foundation-sites#10828
and gulpjs/gulp#1631
The text was updated successfully, but these errors were encountered: