Fix the issue #181 #182
Fix the issue #181 #182
Conversation
index.js
Outdated
| env = mergeConfigToEnvFlags(env, cfg); | ||
| env.configProps = cfg; | ||
|
|
||
| this.execute(env, handleArguments); |
There was a problem hiding this comment.
should this be cli instead of this? - I'm thinking that will help when we switch to promises.
lib/shared/completion.js
Outdated
| @@ -1,5 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| /* eslint no-console: off */ | |||
There was a problem hiding this comment.
Let's just add this to the .eslintrc file
|
@phated I've modified what you pointed out.
I don't want to commit my comment into master. I just wanted to use such word or style of comment. So I'm OK that you squash or modify my commit comment. |
|
@sttk Thanks for cleaning up the commit messages and my couple of comments. I force-pushed to your branch with some nitpicks in wording. I plan to merge this into master as soon as CI finishes and I'm hoping to do some work on outstanding issues today. |
|
Btw, this will also close #142 because Liftoff was modified to only log if we don't have a success |
|
@phated Thank you so much for reviewing and merging! |
This PR uses Liftoff v3.1 and moves the loading of config files before the autoloads of modules.
About adding more config flags and overriding flags from config file by ones from cli args, I will send another PRs.