Enable handling of all pycbc_pygrb_efficiency in workflow #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
approved these changes
Sep 17, 2024
pycbc/workflow/grb_utils.py
Outdated
| @@ -539,6 +543,8 @@ def make_pygrb_plot(workflow, exec_name, out_dir, | |||
| node.add_opt('--y-variable', tags[0]) | |||
| # Quantity to be displayed on the x-axis of the plot | |||
| elif exec_name == 'pygrb_plot_stats_distribution': | |||
| seg_filelist = FileList([resolve_url_to_file(sf) for sf in seg_files]) | |||
There was a problem hiding this comment.
As with the other PR, we should not be passing around URLs (or paths) to files, but passing around File objects wherever possible. If seg_files is read in the top-level workflow generator, it would be better to immediately convert to a File object.
|
@spxiwh, I followed up on your comments, thanks. I reran the post-processing portion of the run and successfully produced a new webpage which looks like the original one. |
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* Enable handling json file output from pycbc_pygrb_efficiency in pygrb workflow * Removing resolve_url_to_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is the second of the PRs promised in #4872.
It brings the PyGRB workflow utilities up to date with the output produced
pycbc_pygrb_efficiency. Specifically, this script now generates a json file with exclusion distances, which the (post processing) workflow generator needs to catch and handle appropriately. The json file is intended to be used by the executable introduce in #4756 to display exclusion distances in a table.This change affects: PyGRB
This change changes: presentation of scientific output
This change will come to full circle with another PR to invoke and display the generation of the exclusion distances table.
Links to any issues or associated PRs
This is the 2nd PR of a series opened by #4872 but it does not depend on it.
Testing performed
A full results webpage is available but it requires more changes than this one to produce.