setup_pygrb_minifollowups cleaner #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
spxiwh
approved these changes
Sep 17, 2024
pycbc/workflow/grb_utils.py
Outdated
| @@ -710,14 +710,12 @@ def setup_pygrb_minifollowups(workflow, followups_file, | |||
| tags=tags) | |||
| node = exe.create_node() | |||
|
|
|||
| node.add_input_opt('--trig-file', resolve_url_to_file(trigger_file)) | |||
There was a problem hiding this comment.
Ideally, the resolve_url_to_file call would not happen here, but instead be done as soon as the trigger_file is read in (presumably a few levels above this). The help states that trigger_file is a pycbc.workflow.File, which is what we would want, but not what seems to be happening if this is needed.
|
@spxiwh, I followed up on your comments, thanks. I reran the post-processing portion of the run and successfully produced a new webpage which looks like the original one. |
1 task
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* setup_pygrb_minifollowups cleaner * Removing resolve_url_to_file from setup_pygrb_minifollowups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup of
setup_pygrb_minifollowupsStandard information about the request
This change affects: PyGRB
This change will: remove an unused variable (
trig_time) and make the trigger file (trigger_file) a mandatory argument ofsetup_pygrb_minifollowups.Motivation
This is the first PR to breakdown the workflow changes that produce a PyGRB results page with injections, exclusion distances, open box, followups of missed injections, offsource and onsource triggers, timeslides, etc.
Testing performed
See link above to the most recent results webpage.