Function to setup pygrb_grb_info_table jobs #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
approved these changes
Sep 17, 2024
pycbc/workflow/grb_utils.py
Outdated
| @@ -560,30 +560,37 @@ def make_pygrb_plot(workflow, exec_name, out_dir, | |||
| return node, node.output_files | |||
|
|
|||
|
|
|||
| def make_info_table(workflow, out_dir, tags=None): | |||
| """Setup a job to create an html snippet with the GRB trigger information. | |||
| def make_info_table(workflow, exec_name, out_dir, in_files=None, tags=None): | |||
There was a problem hiding this comment.
Can the function be a bit more specific make_grb_info_table at least?
pycbc/workflow/grb_utils.py
Outdated
| workflow.cp.get('workflow', 'trigger-time')) | ||
| node.add_opt('--ra', workflow.cp.get('workflow', 'ra')) | ||
| node.add_opt('--dec', workflow.cp.get('workflow', 'dec')) | ||
| node.add_opt('--sky-error', workflow.cp.get('workflow', 'sky-error')) |
There was a problem hiding this comment.
Why do these need to be read from cp.get? The all-sky workflow has numerous cases where options are shared between codes, and the config files have syntax to support this .... The idea being to avoid these setup codes being unecessarily complex and having the configs specifying, as much as possible, what arguments codes will run with.
…calls from make_pygrb_info_table
|
@spxiwh, I followed up on your comments, thanks. I reran the post-processing portion of the run and successfully produced a new webpage which looks like the original one. |
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* Expand make_info_table to setup pygrb_grb_info_table jobs * Code climate * Cleanup * Update call to make_info_table in PyGRB workflow generator * Renaming make_info_table to make_pygrb_info_table; removing 4 cp.get calls from make_pygrb_info_table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This PR expands the scope of
make_info_tableso it can add jobs to the workflow forpygrb_exclusion_dist_tableas well aspygrb_grb_info_table.This is a: a new feature for PyGRB workflow generation.
This change allows to expand presentation of scientific output in PyGRB webpages
Links to any issues or associated PRs
This change is the 3rd PR of a series started with #4872.
Testing performed
As for the previous two PRs an example of a complete webpage is here, but the full webpage will be reproducible only once all workflow changes are on master.