Skip to content

Conversation

@joe-saronic
Copy link
Contributor

No description provided.

@joe-saronic joe-saronic force-pushed the list-dependencies-j branch from 383cb1c to b5757f1 Compare May 2, 2025 10:16
@gwbres
Copy link
Owner

gwbres commented May 2, 2025

Hello,

you should not use this library but switch to zbus system instead, which uses proper built in API

I'll continue merging any proposal to this library, until this is marked as archived.
But I don't have time to fix proposals (focused on other topics), any proposal must pass CI directly

@joe-saronic
Copy link
Contributor Author

@gwbres Understood. We are using it on a work project, at least until we switch to zbus or dbus. I'll fix the CI issues shortly. Aside from a cursory review of the concept, my intention was certainly not to make you fix my coding errors.

@gwbres
Copy link
Owner

gwbres commented May 2, 2025

No worries, I'm not saying that is what you implied ;) just letting you know.
Please drop a message when you think you have completed your task

@joe-saronic
Copy link
Contributor Author

Oddly enough, I have two tests failing with PermissionDenied errors that I can't reproduce locally. Do you have any ideas why that might be happening?

@joe-saronic joe-saronic force-pushed the list-dependencies-j branch from 01d5467 to 79deb93 Compare May 17, 2025 01:14
@joe-saronic
Copy link
Contributor Author

@gwbres I finally figured out why the two tests are failing. They require root access. Is there some way to bypass that?

@joe-saronic
Copy link
Contributor Author

Bump

@gwbres
Copy link
Owner

gwbres commented Jun 3, 2025

don't have time to spend on this, as previously stated.
"Testing strategy" is obviously terribly wrong, and I will not investigate.
Either fix it and like I said, I'm always happy to merge proposals, or move on to another topic

@symbx
Copy link
Contributor

symbx commented Jun 25, 2025

@gwbres I finally figured out why the two tests are failing. They require root access. Is there some way to bypass that?

I found solution. There was some issues with service names and default available services in test image, root access is not necessary.
Created PR for fix ( #40 ) and hope or both PR ( this one and #39 ) will be unblocked

@joe-saronic joe-saronic force-pushed the list-dependencies-j branch from 79deb93 to 0218e4c Compare June 26, 2025 05:38
@joe-saronic
Copy link
Contributor Author

I rebased on the recently merged fix. This should be OK now.

@gwbres gwbres merged commit 716b2e2 into gwbres:main Jun 26, 2025
1 check passed
@gwbres
Copy link
Owner

gwbres commented Jun 26, 2025

If you need new versions, feel free to push the version bumps, I'll just release them

@joe-saronic joe-saronic deleted the list-dependencies-j branch June 26, 2025 06:01
@joe-saronic
Copy link
Contributor Author

Will do. A version tag will be helpful here.

@joe-saronic
Copy link
Contributor Author

I modeled #41 after v0.2.0

@gwbres
Copy link
Owner

gwbres commented Jun 26, 2025

great, like I said if everything passes I have zero issue merging any proposal

it's just I don't have time to dedicate to this topic anymore. And like I said, this tool should not be used and correct solutions (using dbus) should be prefered. Maybe at some point this will be archived or I'll pass on the maintenance. Until then, I don't mind merging and releasing

@joe-saronic
Copy link
Contributor Author

Much appreciated. I understand the deficiencies in this tool, but we've got it meeting requirements in enough places that it's worth keeping around for a bit longer. Thanks for seeing this through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants