Skip to content

Conversation

@symbx
Copy link
Contributor

@symbx symbx commented Jun 25, 2025

Issues causing tests to fail:

  • Missing services in test image (test_is_active) - ubuntu uses "ssh" name instead "sshd" and does not have "ntpd", "dropbear" by default
  • Failed to check services without specifying type (test_service_unit_construction) with some services (observed with proc-sys-fs-binfmt_misc
  • Specific service type for swap
  • Clippy complains about using Error::new(ErrorKind::Other... instead of Error::other(...

These are only tests I saw failing. I hope this helps to unblock other PRs

@symbx
Copy link
Contributor Author

symbx commented Jun 25, 2025

Changes may break local tests if local system does not have rsync, nginx services or have ssh as sshd.
May be there way to made test in better way (beside listing units, as it may skip test entirely)

@joe-saronic
Copy link
Contributor

Thank you for this!

@gwbres gwbres merged commit af0449d into gwbres:main Jun 26, 2025
1 check passed
@symbx symbx deleted the fix_ci_test branch June 26, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants