Fix empty stack trace/context variables #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes gwomacks#336 The generated class names of anonymous classes contain a null byte which is encoded into XML by xdebug. But since null bytes are illegal entities in XML this breaks parsing of those messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shot at fixing #336.
Problem:
null bytein their class namesxdebugencodes thisnull bytein its XML messages - producing actually invalid XMLxml2js/saxis unable to parse this XMLFor more details see #336 (comment).
Solution: replace all
null byteentities in the XML string before passing it toxml2js