Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong warning when running on Lear Siegler ADM-5 terminal #505

Closed
fstark opened this issue May 11, 2024 · 1 comment
Closed

Wrong warning when running on Lear Siegler ADM-5 terminal #505

fstark opened this issue May 11, 2024 · 1 comment

Comments

@fstark
Copy link

fstark commented May 11, 2024

(Issue reproduced on Linux)

How to reproduce:
Enter TERM=adm5 less

Expected Result:

Missing filename ("less --help" for help)

Result:

WARNING: terminal is not fully functional
Missing filename ("less --help" for help)

There is a spurious warning that the terminal is not fully functional.

fstark added a commit to fstark/less that referenced this issue May 11, 2024
gwsw added a commit that referenced this issue Sep 9, 2024
Fix for issue #505 ("Wrong warning when running on Lear Siegler ADM-5 terminal")

The cheaper function that compares two ways of using termcap sets missing_cap to 1 if both ways are unavailable. This function is used to choose between using "al" or "sr" ("add line" or "scroll reverse") to add a line at the top of the screen. None of those are available on an ADM5 terminal.

However, less already has support for terminal that lacks reverse scroll, and is correctly setting the no_back_scroll, making the warning wrong.

Source code already had a provision to avoid using cheaper if none of the capabilities were available, but it was only used for OS2. I enabled this for all builds. I don't see any potential for any regression.

Related to #505.
Manually merged from #506.
@gwsw
Copy link
Owner

gwsw commented Nov 7, 2024

Fixed in deb4981.

@gwsw gwsw closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants