-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error if waved cannot find public/private dir #2130
Comments
Hi I would like to work on this! |
Go ahead and good luck then @kaitlyncliu! |
Hi, just wanted to update that I am working with @92ammarraza on this issue for a class project so he is making the PR! |
@mturoci is this still up for grabs? |
Hi, I submitted a PR for this change request. Let me know how it looks and if you would like any changes. Thanks! |
What is the reasoning process behind disallowing this? In other words, if this is solely there for dev experience and has no security reasons, I'd suggest to lower it to a warning. In its current state, this is a breaking change for existing pipelines. @mturoci |
The original goal was to improve DX since specifying folders is a bit inconvenient (has to be relative to waved binary rather than main app file). This way, wrong path would be reported right away. However, I didn't consider the usecase you mentioned above, which is totally valid, so lowering to warn makes sense. Changed in 6ebfbf9. |
Is your feature request related to a problem? Please describe
Debugging public/private dir configuration is painful currently, because if the path is not correct, the operation fails silently and waved starts nonetheless.
Describe the solution you'd like
Notify the user about the inaccessible path during waved startup.
The text was updated successfully, but these errors were encountered: