feat: Raise error if waved cannot find public/private dir #2130 #2378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.Closes #2130
As requested in the ticket, I have made changes so that an error is thrown when an invalid public or private directory is provided when starting the wave server. The following validation was added to
server.go
in thesplitDirMapping()
function:I tested the change by temporarily modifying the
run
target in theMakefile
to have various combinations of valid and invalid values forpublic-dir
andpublic-dir
. Here are screen shots of a couple examples where invalid directories were given:And here are screen shots where valid directories are provided and I also included the browser in the screen shots to show that the server came up fine and the custom directory is accessible:
A couple things to note:
make run
rather than using thewaved
command is sufficient. I normally run everything in my dev environment withmake
, but if you would rather I test using thewaved
command then let me know.Let me know if you have any questions or would like me to make any changes. Thanks!