Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calckey support #1731

Closed
wants to merge 57 commits into from
Closed

Calckey support #1731

wants to merge 57 commits into from

Conversation

ThatOneCalculator
Copy link
Contributor

fruye and others added 16 commits March 23, 2023 23:15
to be fair, I didn't test it on a real mastodon server. I just hope it works. I also don't think it matters much anyway as this is a fork for calckey? idk please let me know if I need to test it on mastodon too.

It's a bit silly implementation as mfm is just escaped to plaintext and the announcement title is glued to `content`, but overall I think it works fine :)

Reviewed-on: https://codeberg.org/calckey/megalodon/pulls/4
Co-authored-by: fruye <fruye@unix.dog>
Co-committed-by: fruye <fruye@unix.dog>
From what I've tested, account fields are only visible when searching or
directly requesting accounts. Misskey strips some of the account data in
note requests, making this is not visible there.
Calckey frontend uses API endpoints with 'favourite' in the name to add
bookmarks. For "real" favorites it sends a 'reaction'.
Calckey thinks that favorites are bookmarks, which made these functions
not quite behave as they supposed to.
…ctions' (#6) from fruye/megalodon:bookmarks-and-favourites into master

Reviewed-on: https://codeberg.org/calckey/megalodon/pulls/6
@h3poteto
Copy link
Owner

Sorry, I can't merge this PR because too big and it includes changes other than Calckey. Can I create a new PR dedicated to Calckey based on this PR?

@ThatOneCalculator
Copy link
Contributor Author

The Misskey fixes in this PR are also needed for Calckey, but you can create a new PR from this.

@Y0ngg4n
Copy link

Y0ngg4n commented Sep 13, 2023

@ThatOneCalculator Any news about this PR?

@ThatOneCalculator
Copy link
Contributor Author

Don't ask me, ask the maintainer. For now, I maintain my own fork.

@Y0ngg4n
Copy link

Y0ngg4n commented Sep 13, 2023

@h3poteto any news?

@h3poteto
Copy link
Owner

There is nothing.
I don't have much motivation for this feature right now.

@ThatOneCalculator
Copy link
Contributor Author

@Y0ngg4n if you want a version of megalodon that supports Firefish (formerly Calckey), here's our version of megalodon in our monorepo: https://git.joinfirefish.org/firefish/firefish/-/tree/develop/packages/megalodon?ref_type=heads

@h3poteto
Copy link
Owner

Thank you. Firefish support has started.

@h3poteto h3poteto closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants