Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #1911 Impelement firefish client #1915

Merged
merged 4 commits into from
Sep 21, 2023
Merged

refs #1911 Impelement firefish client #1915

merged 4 commits into from
Sep 21, 2023

Conversation

h3poteto
Copy link
Owner

@h3poteto h3poteto commented Sep 20, 2023

refs #1911
Refs #1731

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

megalodon/src/firefish.ts|1893 col 29| Don't use {} as a type. {} actually means "any non-nullish value".
megalodon/src/firefish.ts|1896 col 67| Don't use {} as a type. {} actually means "any non-nullish value".
megalodon/src/firefish.ts|1945 col 59| Don't use {} as a type. {} actually means "any non-nullish value".
megalodon/src/firefish.ts|2179 col 28| Don't use {} as a type. {} actually means "any non-nullish value".
megalodon/src/firefish.ts|2194 col 28| Don't use {} as a type. {} actually means "any non-nullish value".
megalodon/src/firefish/entities/announcement.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/app.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/blocking.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/createdNote.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/emoji.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/favorite.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/field.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/file.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/follow.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/followRequest.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/hashtag.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/instance.ts|4 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/list.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/meta.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/mute.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/note.ts|6 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/notification.ts|4 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/poll.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/reaction.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/relation.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/session.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/stats.ts|1 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/user.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/userDetail.ts|4 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars
megalodon/src/firefish/entities/userkey.ts|3 col 11| 'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
megalodon/src/firefish.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,11 @@
namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@@ -0,0 +1,10 @@
namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@@ -0,0 +1,10 @@
/// <reference path="userDetail.ts" />

namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@@ -0,0 +1,7 @@
/// <reference path="note.ts" />

namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@@ -0,0 +1,7 @@
namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@@ -0,0 +1,6 @@
namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@@ -0,0 +1,9 @@
namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@@ -0,0 +1,20 @@
/// <reference path="emoji.ts" />

namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

/// <reference path="emoji.ts" />
/// <reference path="note.ts" />

namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@@ -0,0 +1,8 @@
/// <reference path="user.ts" />

namespace FirefishEntity {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
'FirefishEntity' is defined but never used @typescript-eslint/no-unused-vars

@h3poteto h3poteto marked this pull request as ready for review September 20, 2023 16:19
@h3poteto h3poteto merged commit debd767 into master Sep 21, 2023
4 checks passed
@h3poteto h3poteto deleted the iss-1911 branch September 21, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant