Mark item done after validity check #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2018 14:21
If an item is not a string, then it's invalid, and there's no point in requeuing it since it will still be invalid. Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
By moving the call to `defer` below, we make sure that we don't mark invalid items as `Done`, since the `defer` is now below the check for validity. Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
|
#122 is already closed? |
|
Updated, was the wrong issue, but also I'm not sure there's a connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves two things about the way in which we handle the queue:
Forgetfor invalid items, so that we don't get them in the queue again.May or may not close #122, not sure because I haven't been seeing that error in a while.Closes #222.