Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark item done after validity check #274

Merged
merged 2 commits into from
May 14, 2018
Merged

Mark item done after validity check #274

merged 2 commits into from
May 14, 2018

Commits on May 14, 2018

  1. controller/v1beta2: Forget invalid items in queue 

    If an item is not a string, then it's invalid, and there's no point in
requeuing it since it will still be invalid.

Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
    Lorenzo Manacorda committed May 14, 2018
    Configuration menu
    Copy the full SHA
    d8e8dcf View commit details
    Browse the repository at this point in the history

  2. controller/v1beta2: Defer defer 

    By moving the call to `defer` below, we make sure that we don't mark
invalid items as `Done`, since the `defer` is now below the check for
validity.

Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
    Lorenzo Manacorda committed May 14, 2018
    Configuration menu
    Copy the full SHA
    acade9b View commit details
    Browse the repository at this point in the history