Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bidding music #220

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Add bidding music #220

merged 2 commits into from
Aug 29, 2023

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Aug 27, 2023

  • Add remixed version of menu theme as bidding theme
  • Tweak menu music so that it is louder and has greater audio quality

Closing #219

@toberge
Add bidding music
314f007 
Remixed version of the menu theme
@toberge
Upgrade menu music
d8cff6c 
Use WAV instead of OGG for a slight improvement in sound quality, and
tune up the volume by decreasing the large difference in strength that was
present between parts of the track before.
@toberge toberge self-assigned this Aug 27, 2023
@toberge toberge linked an issue Aug 27, 2023 that may be closed by this pull request
Add bidding-specific music #219
Closed
Fueredoriku
Fueredoriku approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!! 😁

Not only is this very nice for the more frantic bidding, but we can reuse the old theme in the new planned cutscene where the auctioneer presents items before the bidding starts as a cool transition, so it's great that you left it in!

@toberge toberge merged commit 769de4d into dev Aug 29, 2023
2 checks passed
@toberge toberge deleted the feature/bidding-music branch August 29, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fueredoriku Fueredoriku Fueredoriku approved these changes

@ThomasJGabrielsen ThomasJGabrielsen Awaiting requested review from ThomasJGabrielsen

Assignees

@toberge toberge

Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add bidding-specific music
2 participants
@toberge @Fueredoriku