Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent nullreference in soda can sounds + misc other exceptionish fixes #840

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Oct 1, 2024

What could happen here, with the soda can hit sounds using the explosion's audio source:

  • Soda can explodes
  • Explosion destroys itself
  • Hitbox is shot/damaged again
  • No audiosource!

Also fixes a bunch of semi-related issues.

@toberge toberge changed the title Prevent nullreference in soda can sounds Prevent nullreference in soda can sounds + misc other exceptionish fixes Oct 1, 2024
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, code looks fine and manual testing didn't indicate anything wrong 👍

@toberge toberge merged commit 4f41dea into dev Oct 1, 2024
3 checks passed
@toberge toberge deleted the fix/prevent-soda-nullref branch October 1, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants