Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused alt-hero in project md files #2722

Closed
37 of 39 tasks
JessicaLucindaCheng opened this issue Jan 27, 2022 · 15 comments
Closed
37 of 39 tasks

Remove unused alt-hero in project md files #2722

JessicaLucindaCheng opened this issue Jan 27, 2022 · 15 comments
Assignees
@vmaineng
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue epic P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone
08. Team workflow

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jan 27, 2022 •
edited by vmaineng
Loading

Dependency

Overview

As a developer, I want to make sure unused code is removed from the codebase in project cards so that

  • time to load the website is as low as possible,
  • it's easier to understand the code, and
  • time to review the code is reduced.

For this epic, we will write issues to remove the alt-hero field in the project md files, which will be added as Dependency items above.

Details

In project md files, image-hero is a decorative background image and alt-hero is the alt text associated with image-hero. However, alt-hero text is not used anywhere in our codebase since the image-hero is used as an SCSS background image.

Moreover, if the image-hero were to be used in an img HTML tag in the future, the alt text for all the image-hero images would be alt="", which could be set programmatically for all the alt properties associated with each image-hero.

Developers will write issues for this epic by following the "Instructions for Developers" in the Instructions tab of the HfLA-Website: Remove unused alt-hero field from project mds Google Sheet and using the Project md file: Removing unused alt-hero field issue template. After an issue is created, the technical lead(s) will review each issue by following the "Instructions for Technical Leads" in the Instructions tab of the HfLA-Website: Remove unused alt-hero field from project mds Google Sheet.

Action Items

  • Write issues for this epic. See this spreadsheet HfLA-Website: Remove unused alt-hero field from project mds Google Sheet and the issues that need to be written.
  • Once all the issues in the Dependency section are checked off and closed, use the search function in your IDE to check the following for the .md files in _projects:
    • There is no alt-hero: field in any of the .md files in _projects. (If you are using VSCode as your IDE, you can search for alt-hero: and restrict the search by filling in the "files to include" field with _projects. Other IDEs may have similar search capabilities.)
      • If you find any alt-hero: fields in any of the .md files in _projects, list the .md file(s) you found them in in a new comment below.
      • If you find no alt-hero: fields in any of the .md files in _projects, then in a new comment below say you found no alt-hero: fields and close the issue.

Resources/Instructions

Accessibility information
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Jan 27, 2022
@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Complexity: Large P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Collaborative Work Ready for Prioritization and removed role missing Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing labels Jan 27, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Figure out if alt-hero in project.md template should be removed or changed to null Figure out if alt-hero in project.md template should be removed or changed to alt-hero: '' Jan 27, 2022
@JessicaLucindaCheng JessicaLucindaCheng mentioned this issue Jan 27, 2022
Closed
3 tasks
@Providence-o Providence-o mentioned this issue Jan 29, 2022
Open
2 tasks
@JessicaLucindaCheng JessicaLucindaCheng changed the title Figure out if alt-hero in project.md template should be removed or changed to alt-hero: '' DRAFT: Figure out if alt-hero in project.md template should be removed or changed to alt-hero: '' Feb 1, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Figure out if alt-hero in project.md template should be removed or changed to alt-hero: '' DRAFT: Remove unused alt-hero in project.md files Feb 12, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Remove unused alt-hero in project.md files DRAFT: Remove unused alt-hero in project.md template and project md files Feb 12, 2022
@JessicaLucindaCheng JessicaLucindaCheng added size: 13+pt Must be broken down into smaller issues epic and removed size: 2pt Can be done in 7-12 hours labels Feb 26, 2022
This was referenced Feb 26, 2022
Closed
Closed
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Remove unused alt-hero in project.md template and project md files DRAFT: Remove unused alt-hero in project md files Feb 27, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Remove unused alt-hero in project md files Remove unused alt-hero in project md files Feb 27, 2022
This was referenced Jun 3, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@JessicaLucindaCheng JessicaLucindaCheng removed their assignment Jun 3, 2022
@JessicaLucindaCheng JessicaLucindaCheng added Dependency An issue is blocking the completion or starting of another issue and removed Status: Updated No blockers and update is ready for review labels Jun 3, 2022
@JessicaLucindaCheng

This comment was marked as resolved.

Sign in to view
@JessicaLucindaCheng JessicaLucindaCheng added Draft Issue is still in the process of being created and removed Draft Issue is still in the process of being created labels Sep 12, 2022
@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on size: 1pt Can be done in 4-6 hours size: 0.25pt Can be done in 0.5 to 1.5 hours and removed Dependency An issue is blocking the completion or starting of another issue size: 2pt Can be done in 7-12 hours size: 1pt Can be done in 4-6 hours labels Dec 2, 2022
@JessicaLucindaCheng
Copy link
Member Author

I pulled this out of the Ice Box because all the dependencies have been met.

@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Dec 2, 2022
@vmaineng vmaineng self-assigned this Dec 2, 2022
@vmaineng vmaineng mentioned this issue Dec 18, 2022
Closed
34 tasks
@vmaineng
Copy link
Member

The only 'alt-hero' fields are located in project-md-file--removing-unused--alt-hero--field.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmaineng vmaineng

Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue epic P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
08. Team workflow
Development

No branches or pull requests
5 participants
@SAUMILDHANKAR @JessicaLucindaCheng @ExperimentsInHonesty @Providence-o @vmaineng