Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused alt-hero field from open-community-survey.md project file #3208

Closed
3 of 4 tasks
Tracked by #2722
JessicaLucindaCheng opened this issue Jun 3, 2022 · 5 comments · Fixed by #3700
Closed
3 of 4 tasks
Tracked by #2722
Assignees
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jun 3, 2022

Overview

As a developer, I want to make sure unused code is removed from the codebase in project cards so that

  • time to load the website is as low as possible,
  • it's easier to understand the code, and
  • time to review the code is reduced.

Details

In project md files, image-hero is a decorative background image and alt-hero is the alt text associated with image-hero. However, alt-hero text is not used anywhere in our codebase since the image-hero is used as an SCSS background image.

Moreover, if the image-hero were to be used in an img HTML tag in the future, the alt text for all the image-hero images would be alt="", which could be set programmatically for all the alt properties associated with each image-hero.

Action Items

  • For the file _projects/open-community-survey.md, remove line 8 for the alt-hero
alt-hero: 'Silhouette of buildings and houses with different colors, shapes and styles.'

Resources/Instructions

File and code links you will need to work on this issue

  • Directory to find the page once you have it in your IDE: _projects/open-community-survey.md
  • Click on the link below to see the source file code:
    alt-hero: 'Silhouette of buildings and houses with different colors, shapes and styles.'

Information about WCAG

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Size: Good second issue size: 0.5pt Can be done in 3 hours or less labels Jun 3, 2022
@github-actions

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Hi @Skydodle, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Skydodle
Copy link
Member

Skydodle commented Nov 8, 2022

Availability: Wednesdays, Fridays & Saturday

ETA: By Sunday 11/13 end of day

@ExperimentsInHonesty
Copy link
Member

This issue is QAed and is fine.

While I was QAing this issue, I realized that there is also alt text in the markdown project files for the image we use on the homepage and on the mini card.

  1. We have to make an epic to clean those up so that they are WCAG compliant in case we do need to use them
  2. Some of the images contain text that is not conveyed in the text below the images on the home & project pages (heart, vrms, etc.). We are using the alt text on the home and project page (same include).

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Nov 27, 2022

This whole thing was resolved by changing the alt text for vrms to "Volunteer Relationship Management (VRMS)" in the spreadsheet related to this issue.
#2613

There are no other outstanding items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

3 participants