Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed line 8 unused alt-hero field #3700

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Removed line 8 unused alt-hero field #3700

merged 1 commit into from
Nov 10, 2022

Conversation

Skydodle
Copy link
Member

@Skydodle Skydodle commented Nov 8, 2022 •
edited
Loading

Fixes #3208

What changes did you make and why did you make them ?

  • Removed line 8 because the alt-hero field is not used anywhere in the website

no visual change on the website

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Skydodle-remove-unused-field-3208 gh-pages
git pull https://github.com/Skydodle/website.git remove-unused-field-3208

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Nov 8, 2022
@jyaymie jyaymie self-requested a review November 8, 2022 20:04
@jyaymie
Copy link
Member

jyaymie commented Nov 8, 2022

Review ETA: 11/8/22 2pm
Availability: 11/8/22 Flexible

@luiderek luiderek self-requested a review November 8, 2022 20:06
@luiderek
Copy link
Member

luiderek commented Nov 8, 2022

Review ETA: 10m
Availability: till 10pm pdt

jyaymie
jyaymie approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Skydodle! You took care of the issue's action item appropriately. And I like your branch name - brief yet effective in helping us understand the issue at a glance.

luiderek
luiderek approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@luiderek luiderek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff @Skydodle. The pull request is coming from a properly named forked branch, and you've hit the right file; Just be aware the action items on the issue itself can be checked off when they're finished.

@arpitapandya arpitapandya merged commit 87fbbc8 into hackforla:gh-pages Nov 10, 2022
@jefflueck jefflueck assigned jefflueck and unassigned jefflueck May 4, 2023
@jefflueck jefflueck requested review from jefflueck and removed request for jefflueck May 4, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyaymie jyaymie jyaymie approved these changes

@luiderek luiderek luiderek approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from open-community-survey.md project file
6 participants
@Skydodle @jyaymie @luiderek @jefflueck @ExperimentsInHonesty @arpitapandya