Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused alt-hero field from expunge-assist.md project file #3196

Closed
4 tasks done
Tracked by #2722
JessicaLucindaCheng opened this issue Jun 3, 2022 · 12 comments · Fixed by #3677
Closed
4 tasks done
Tracked by #2722

Remove unused alt-hero field from expunge-assist.md project file #3196

JessicaLucindaCheng opened this issue Jun 3, 2022 · 12 comments · Fixed by #3677
Assignees
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jun 3, 2022

Overview

As a developer, I want to make sure unused code is removed from the codebase in project cards so that

  • time to load the website is as low as possible,
  • it's easier to understand the code, and
  • time to review the code is reduced.

Details

In project md files, image-hero is a decorative background image and alt-hero is the alt text associated with image-hero. However, alt-hero text is not used anywhere in our codebase since the image-hero is used as an SCSS background image.

Moreover, if the image-hero were to be used in an img HTML tag in the future, the alt text for all the image-hero images would be alt="", which could be set programmatically for all the alt properties associated with each image-hero.

Action Items

  • For the file _projects/expunge-assist.md, remove line 9 for the alt-hero
alt-hero: 'Expunge Assist project logo'

Resources/Instructions

File and code links you will need to work on this issue

  • Directory to find the page once you have it in your IDE: _projects/expunge-assist.md
  • Click on the link below to see the source file code:
    alt-hero: 'Expunge Assist project logo'

Information about WCAG

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Size: Good second issue size: 0.5pt Can be done in 3 hours or less labels Jun 3, 2022
@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as outdated.

@rolzar
Copy link
Member

rolzar commented Oct 4, 2022

Availability: 5 hrs.
ETA: 10/7.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Oct 7, 2022
@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Oct 14, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Oct 14, 2022
@bishrfaisal
Copy link
Member

Hey @rolzar, we see that you have taken up your second issue. Awesome work so far! It has been 2 weeks since you self-assigned, have you run into any obstacles? If so, please let us know and we would be happy to help!

@github-actions
Copy link

@rolzar

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 18, 2022 at 12:33 AM PST.

@bishrfaisal
Copy link
Member

Hi @rolzar! We haven't heard from you since October 4th (19 days ago). Hope you are okay. We have un-assigned you from this issue. Please feel free to pickup a new issue from the prioritized backlog when you return!

@bishrfaisal bishrfaisal removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Oct 23, 2022
@roslynwythe roslynwythe self-assigned this Oct 27, 2022
@github-actions
Copy link

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roslynwythe
Copy link
Member

roslynwythe commented Oct 27, 2022 via email

@roslynwythe roslynwythe removed their assignment Oct 27, 2022
@roslynwythe
Copy link
Member

I'm still proceeding down the pre-work checklist and just learned that not supposed to assign a "good second issue" until my first issue PR has been merged, so therefore I am unassigning myself.

@roslynwythe roslynwythe self-assigned this Oct 28, 2022
@github-actions
Copy link

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roslynwythe
Copy link
Member

roslynwythe commented Oct 28, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

5 participants