Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed alt-hero from _projects/expunge-assist.md issue 3196 #3677

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

roslynwythe
Copy link
Member

Fixes #3196

What changes did you make and why did you make them ?

  • removed alt-hero by deleting line 9 from _projects/expunge-assist.md, because alt-hero was not being used.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

There were no visual changes to the site

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b roslynwythe-remove-alt-hero#3196 gh-pages
git pull https://github.com/roslynwythe/website.git remove-alt-hero#3196

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue Status: Updated No blockers and update is ready for review labels Oct 31, 2022
Copy link
Member

@gstemmann gstemmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you added your branch to the proper repo in hfla website: hackforla:gh-pages. great job. And it looks like you deleted the correct line from the expunge-assist.md for the alt-hero.

@MattPereira MattPereira self-requested a review October 31, 2022 18:10
@MattPereira
Copy link
Contributor

Review ETA: 11:30 PM 10/31/22
Availability: 1 hour

Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @roslynwythe ! 👍

You removed the alt-hero line and executed the pull request beautifully by linking the issue number, listing your changes, and providing the reason for the changes.

@arpitapandya arpitapandya self-requested a review October 31, 2022 18:36
@arpitapandya
Copy link
Member

ETA: EOD 2022-10-31
Availability: 15 minutes

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks correct! Great job! @roslynwythe

@arpitapandya arpitapandya merged commit 938e343 into hackforla:gh-pages Oct 31, 2022
@roslynwythe roslynwythe deleted the remove-alt-hero#3196 branch March 1, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from expunge-assist.md project file
5 participants