Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issue template for reporting spell check warning #5655

Closed
3 tasks
roslynwythe opened this issue Oct 3, 2023 · 4 comments
Closed
3 tasks

Create issue template for reporting spell check warning #5655

roslynwythe opened this issue Oct 3, 2023 · 4 comments
Labels
Complexity: Medium Draft Issue is still in the process of being created feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Milestone

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Oct 3, 2023

Overview

We need to create an issue template for reporting spell check "unknown word" warnings, for use when a spell check warning appears in a pull request and the warning cannot be resolved within the pull request process

Action Item

Resources/Instructions

Manually creating a single issue template for your repository

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Oct 3, 2023
@roslynwythe
Copy link
Member Author

roslynwythe commented Oct 3, 2023

Issue Title: Resolve warning spell check warnings "unknown word": [INSERT WORDS] in [FILE]

Overview

We need to resolve spell checker warning by correcting the misspelling(s), excluding the term(s) from spell checking, or excluding the section of code or the entire file from spell checking.

Action Items

  • You must use VS Code as your local text editor to install the VS Code extension for spell checking your codebase, The recommended installation method is to install Code Spell Checker directly from the VS Code text editor1. The extension can also be installed via the VS Code Marketplace website2
  • If the "unknown word" is misspelled, correct the spelling
  • If the "unknown word" should be treated as a word (for example, "markdownify" or "hackforla"), add it to the "words" array in the file cspell.json
  • If the "unknown word" should be completely ignored by the spell checker (for example, the name of an individual), add it to the "ignoreWords" array in the file cspell.json
  • If a file should be excluded from spell checking, add it to the "ignorePaths" array in the file cspell.json
  • If the section of a file should be excluded from spell checking, enclose it in these comments
/* cSpell:disable */

and

/* cSpell:enable */

Resources

Footnotes

  1. Installing Code Spell Checker from the VS Code text editor

  2. Code Spell Checker - VS Marketplace

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added Draft Issue is still in the process of being created Complexity: Medium role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Oct 3, 2023
@roslynwythe
Copy link
Member Author

At the 10/3 Dev Lead meeting it was suggested that this issue template is not required because every developer should have responsibility for resolving spell check warnings, either by correcting a misspelling or by resolving false positives by editing cspell.json.

@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Oct 8, 2023
@roslynwythe roslynwythe changed the title Create issue template for reporting false positive spell check errors Create issue template for reporting spell check Oct 22, 2023
@roslynwythe roslynwythe changed the title Create issue template for reporting spell check Create issue template for reporting spell check warning Oct 22, 2023
@roslynwythe roslynwythe added size: 0.5pt Can be done in 3 hours or less and removed size: 0.5pt Can be done in 3 hours or less labels Oct 22, 2023
@roslynwythe
Copy link
Member Author

@roslynwythe roslynwythe closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Draft Issue is still in the process of being created feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

No branches or pull requests

2 participants