Added Kevin Yu's Profile to Civic Tech Jobs File #7591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluto-bell
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Hi @srinipandiyan thanks for taking this issue on (: I just have a couple of requests so we can move forward with your PR.
- Please rename your branch to something that is specific to the issue you are handling—it is also generally advised to add the issue number. For example:
add-profile-to-civic-tech-7556 - Please re-write the reason for making these changes. While I understand you are taking this issue on as a way to 'go through the steps,' that doesn't clarify what the actual fix is handling. In this case, it appears you are creating a new profile card for Kevin Yu on the Civic Tech Job project so that the website information is up to date.
- Please add related label tags to your PR, this can be found on the right hand side. Some examples for this PR are:
good first issue,role: front end,size: 0.25 pt. These labels help people filter pull requests and also help them know as to whether or not they currently have permission to review your PR.
|
ETA: EOD Oct 16 |
srinipandiyan
changed the title
|
ETA: EOD |
codyyjxn
requested changes
Oct 15, 2024
There was a problem hiding this comment.
hey @srinipandiyan
Things that need to be changed:
- The branch name needs to be related to the issue fixed.
- Also the title of this pr needs to be a bit more descriptive.
- You also need to add some labels to show what kind of issue this is and also so others know if this is frontend or backend related. The issue labels should match with the original issue.
Things that went well :
- You did make the right changes to the files
_projects/civic-tech-jobs.md - You provided visuals changes.
Keep it up ! if you have any questions feel free to leave any messages.
srinipandiyan
added
good first issue
|
I've made the required changes to the PR. Thank you for your guidance. @pluto-bell @8alpreet @codyyjxn |
srinipandiyan
changed the title
srinipandiyan
changed the title
|
Closed current PR and opened new PR here: #7598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7556
What changes did you make?
civic-tech-jobs.mdfile to include Kevin Yu's contact info.Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied