-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Kevin Yu's profile to Civic Tech Job section of Projects Page #7598
Added Kevin Yu's profile to Civic Tech Job section of Projects Page #7598
Conversation
Review ETA: 8 PM 10/16/24 (EDT) |
Hi, @srinipandiyan ! I appreciate the clear details in I'm not able to pull the date from your branch due to the branch conflicts. You might forget to pull/sync from the Branch conflicts: |
Hi @siyunfeng, I've synced the PR. Please try again at your convenience. Thank you! Best, Srini |
Review ETA: EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, @srinipandiyan !
The changes you made are applicable to the issue. The before-and-after screenshots you provided are helpful to show the changes.
Improvements:
- Run
git pull
fromgh-pages
before working on the issue and submitting the PR to prevent branch conflicts in the future - Update the before-and-after screenshots after updating your PR if the view changed
- Name the branch with more specific details, such as
add-kevin-yu-to-civic-tech-job-7556
Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @srinipandiyan great job on taking on this issue.
The issue is linked correctly and the branch name is clear. Thank you for also providing the screenshots which help anyone see what changes were made.
Great Job! Keep it up.
Fixes #7556
What changes did you make?
civic-tech-jobs.md
file to include Kevin Yu's profile info:Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied