Skip to content
This repository was archived by the owner on Jul 6, 2019. It is now read-only.

Conversation

@farcaller
Copy link
Member

This fixes lifetimes broken by lifetime elision.

Cleaning up lifetimes is tracked in #115.

Also fixed rlib dependency tracker, an issue with broken PT if compiled with -O2. Libcore version is now matched to rustc version to prevent any compilation failures.

@farcaller farcaller added bug and removed bug labels Jul 21, 2014
@farcaller farcaller mentioned this pull request Jul 21, 2014
@farcaller
Copy link
Member Author

r?

hacknbot added a commit that referenced this pull request Jul 23, 2014
Fixed static lifetimes

Reviewed-by: bgamari
@bgamari
Copy link
Contributor

bgamari commented Jul 23, 2014

@farcaller am I mistaken in thinking that bors expects approvals to be of the form r+ on the last commit?

@farcaller
Copy link
Member Author

bors allows that only from collaborators. Fixed that for you and @errordeveloper ;-)

@farcaller
Copy link
Member Author

Another one thing that I cannot reproduce, and this code doesn't even touch PT!

/home/travis/build/hackndev/zinc/apps/app_empty.rs:1:1: 1:1 error: expected node path but found `=`
/home/travis/build/hackndev/zinc/apps/app_empty.rs:1 #![feature(phase, asm)]

@farcaller
Copy link
Member Author

Ok, so this is nightly fallout in nightly fallout fix. Looking into it...

@farcaller
Copy link
Member Author

Breakage investigation so far:

parser's let ttsvec = tts.iter().map(|x| (*x).clone()).collect(); is broken, it produces a Vec, that somehow starts with EQ token for no apparent reason. Also you can't print that vec, as rustc SIGSEGVs.

Replaced with let ttsvec = Vec::from_slice(tts);.

Now, quote_expr! in system_clock_pt's materialiser is broken as well (guess what, exactly the same error, "unexpected token: ="!).

I have absolutely no idea, what's happening in there, filed rust-lang/rust#15931

@farcaller
Copy link
Member Author

Did a bisect and small investigation, rust-lang/rust#15972.

@farcaller
Copy link
Member Author

Filed rust-lang/rust#15973.

@farcaller
Copy link
Member Author

r? 😄

@farcaller farcaller changed the title Fixed static lifetimes Fixing a bunch of nightly fallouts Jul 25, 2014
hacknbot added a commit that referenced this pull request Jul 25, 2014
Fixing a bunch of nightly fallouts

Reviewed-by: bgamari
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hacknbot hacknbot merged commit db6ff40 into hackndev:master Jul 25, 2014
@farcaller farcaller mentioned this pull request Jul 30, 2014
@farcaller farcaller deleted the fix-lifetimes branch August 9, 2014 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants