Add judge notes view popup per project for admin view#321
Open
balebbae wants to merge 1 commit intohackutd:masterfrom
Open
Add judge notes view popup per project for admin view#321balebbae wants to merge 1 commit intohackutd:masterfrom
balebbae wants to merge 1 commit intohackutd:masterfrom
Conversation
|
@balebbae is attempting to deploy a commit to the Michael Zhao's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MichaelZhao21
requested changes
Feb 24, 2026
Contributor
MichaelZhao21
left a comment
MichaelZhao21
left a comment
There was a problem hiding this comment.
Just some small code syntax things but looks good overall
| const seenProject = judge.seen_projects.find( | ||
| (sp) => sp.project_id === props.project.id | ||
| ); | ||
| if (seenProject && seenProject.notes && seenProject.notes.trim() !== '') { |
Contributor
There was a problem hiding this comment.
You don't need !== '' as a non-empty string is truthy.
| } | ||
| return null; | ||
| }) | ||
| .filter((entry): entry is { judgeName: string; notes: string } => entry !== null); |
Contributor
There was a problem hiding this comment.
This looks horrific as a type, just create an interface for this type pls
Contributor
There was a problem hiding this comment.
Also do we need the !== null? null is also falsey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's currently no way to see notes the judges write on the projects on the admin side. The "/judge/list" already pulls that data, I am just rendering it as a popup for admins.
UI Changes:
Fixes #316
Type of Change
Delete options that do not apply:
Is this a breaking change?