Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new integration [rospogrigio/localtuya] #662

Merged
merged 6 commits into from
Nov 21, 2020

Conversation

rospogrigio
Copy link
Contributor

No description provided.

@hacs-bot hacs-bot bot changed the title New default integration: rospogrigio/localtuya-homeassistant Adds new integration [rospogrigio/localtuya-homeassistant] Oct 19, 2020
@hacs-bot
Copy link

hacs-bot bot commented Oct 19, 2020

Running checks on rospogrigio/localtuya-homeassistant

@rospogrigio
Copy link
Contributor Author

/recheck

@hacs-bot hacs-bot bot added recheck and removed recheck labels Oct 19, 2020
@rospogrigio
Copy link
Contributor Author

/recheck

@KTibow
Copy link
Contributor

KTibow commented Oct 19, 2020

I think you need to make a new release in order for this to work.

@rospogrigio
Copy link
Contributor Author

I think you need to make a new release in order for this to work.

What do you mean? A new PR?

@KTibow
Copy link
Contributor

KTibow commented Oct 19, 2020

@rospogrigio
Copy link
Contributor Author

/recheck

@hacs-bot hacs-bot bot added recheck and removed recheck labels Oct 19, 2020
@rospogrigio
Copy link
Contributor Author

/recheck

@KTibow
Copy link
Contributor

KTibow commented Oct 19, 2020

I think it's failing because the repo's name and the custom component's name conflict, localtuya != localtuya-homeassistant.

@ludeeus
Copy link
Member

ludeeus commented Oct 19, 2020

Repo name does not matter, https://github.com/rospogrigio/localtuya-homeassistant/blob/master/hacs.json#L2 the content_in_root key here, might be the issue, remove it.

Also, remove this from the readme " / Hass.io add-on", 1) Hass.io is an old term 2) it's not an add-on

@hacs-bot hacs-bot bot changed the title Adds new integration [rospogrigio/localtuya-homeassistant] Adds new integration [rospogrigio/localtuya] Oct 19, 2020
@hacs-bot
Copy link

hacs-bot bot commented Oct 19, 2020

Running checks on rospogrigio/localtuya

@rospogrigio
Copy link
Contributor Author

/recheck

@hacs-bot hacs-bot bot added the recheck label Oct 19, 2020
@hacs-bot hacs-bot bot removed the recheck label Oct 19, 2020
@rospogrigio
Copy link
Contributor Author

So now all the checks are passing (apart from the optional fork)... is there anything else I am supposed to do?
Will the Integration be available immediately or a new release of HACS or HA must be released?
Thank you for the support

@KTibow
Copy link
Contributor

KTibow commented Oct 20, 2020

As soon as the PR is merged, it'll be added. All HACS installations check for new repositories about every 30 minutes, and it'll show up as a "New repository".

@rospogrigio
Copy link
Contributor Author

Dear @ludeeus @KTibow , may I kindly ask you when we can expect this PR to be merged? I don't mean to seem pushy in any way, and I know you are probably busy setting up the Conference but we are avoiding publishing new releases of our integration to avoid messing up things with this PR, so it would be useful to know the timing, if any.
Thank you for all your work! 😄

@hacs-bot hacs-bot bot removed the recheck label Nov 21, 2020
@ludeeus ludeeus merged commit e40ade6 into hacs:master Nov 21, 2020
@hacs-bot
Copy link

hacs-bot bot commented Nov 21, 2020

Your repository is now added to HACS 🎉

Here is a few resources that can be useful:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants