Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create localtuya.json #161

Closed
wants to merge 5 commits into from
Closed

Conversation

rospogrigio
Copy link

No description provided.

@homeassistant
Copy link

Hi @rospogrigio,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@rospogrigio
Copy link
Author

/recheck

@KTibow
Copy link
Contributor

KTibow commented Oct 19, 2020

/azurepipelines rerun

@azure-pipelines
Copy link

Command 'rerun' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@KTibow
Copy link
Contributor

KTibow commented Oct 19, 2020

/azurepipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 161 in repo home-assistant/wheels-custom-integrations

@KTibow
Copy link
Contributor

KTibow commented Oct 19, 2020

@rospogrigio can you do an empty commit and force push?

components/localtuya.json Outdated Show resolved Hide resolved
Co-authored-by: Kendell R <KTibow@users.noreply.github.com>
@frenck
Copy link
Member

frenck commented Oct 19, 2020

There is no need to put cryptography in the requirements, as it is a base/core dependency already.
You should remove that requirement from your custom component to prevent issues in the future.

@rospogrigio
Copy link
Author

There is no need to put cryptography in the requirements, as it is a base/core dependency already.
You should remove that requirement from your custom component to prevent issues in the future.

OK I have just done it.

@frenck
Copy link
Member

frenck commented Oct 19, 2020

Thanks, @rospogrigio, that leave your custom integration with no third-party packages to depend on. Is this correct?

If so, you can close this PR, as there is nothing for us to build wheels for in that case.

Updated path of manifest.json
@rospogrigio
Copy link
Author

rospogrigio commented Oct 19, 2020

Yes, that is correct.
I am having a doubt you can probably help me with: one check in this PR request is failing:
hacs/default#662
Because it could not find the manifest.json file.
So I moved it from custom_components/localtuya to the root of my repo but now the check in this PR is failing. Where should the manifest.json be correctly placed? Or should I have 2 copies in different folders?

Edit, I restored the position of the manifest.json file but now the CI check fails, how can I fix it? Sorry for the mess...

Thank you

Restoring manifest.json original position
@KTibow
Copy link
Contributor

KTibow commented Oct 19, 2020

https://dev.azure.com/home-assistant/Core/_build/results?buildId=57029&view=logs&j=5474ba80-d37c-5f5f-2aea-f2830af4b9d6&t=4864bab3-4a04-5955-f9e5-80d721dfcb1d&l=201

The integration in components/localtuya.json, does not seem to have any Python requirements.
Adding it to this repository has no use, since there are nothing to build for it.

Please close.

@rospogrigio
Copy link
Author

OK, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants