-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transforms haddock3 into a python package #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, but what do we gain with it? Is the plan to distribute haddock3 via the python package index?
Why not? Surely not yet, but why not in the future? Anyway, even if we don't want to distribute it in PyPI we gain a lot having haddock3 structure as an authentic package. Some points I consider positive:
|
Transforms haddock3 into a python package. No changes in code were made yet, those are for future pull requests. So far:
haddock
folder insidesrc
, this is the end of relative imports. 😺src
, please read here, in short, avoids issues with relative/absolute imports, and imports on non-installed libraries. I have been working with this setup for a couple of years now, only with positive results.setup.py
haddock3.py
tosrc/haddock/clis/cli.py
. After installation users now have thehaddock3
command installed in the system.setup.py
file because there was something broken withnumpy
andlightdock
, so I decided not to address that issue in this PR.README.rst
for parsing purposes. Now it is empty. In the futureREADME.md
will be converted toREADME.rst
.