-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tool to identify CNS script dependencies #43
Conversation
That looks a nice idea. But we should make it part of the haddock CLI tools, not a simple script. Let me work on that since I pulled #28 . |
Question: why the script needs the Will this dependency on HADDOCK24 disappear after #41 ? If that is so, maybe that second argument can be a fixed folder within haddock3 folder structure. It would be nice to have the output also as you suggested on #42 😉 , looks much prettier. |
Because this is where the CNS protocols are, haddock3 is building on top of it.
I'm afraid we will only keep relying on the production version (either 2.4 or 2.5) for a long time since it has many features that need to be implemented here; both ones that are already there as well as other that are being implement continuously. |
We should start a haddock3 CNS protocol directory
… On 27 Jul 2021, at 12:56, Rodrigo V Honorato ***@***.***> wrote:
Question: why the script needs the /Users/rodrigo/repos/haddock24/protocols ?
Because this is where the CNS protocols are, haddock3 is building on top of it.
Will this dependency on HADDOCK24 disappear after #41 <#41> ? If that is so, maybe that second argument can be a fixed folder within haddock3 folder structure.
I'm afraid we will only keep relying on the production version (either 2.4 or 2.5) for a long time since it has many features that need to be implemented here; both ones that are already there as well as other that are being implement continuously.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABOH5IDVLABSM33OKUWQH7TTZ2GHLANCNFSM5BB26X5Q>.
|
Closing this one since I already used this script to implement the core modules, we don't need to have it in the repository anymore. |
This PR implements a tool to help us clean the CNS dependencies in the HADDOCK core modules and closes #42. It takes the main CNS script as input and the production
protocols
directory; Ex:This script is not very pretty but we can work on it later. :)