Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement rigid body docking #41

Merged
merged 17 commits into from
Jul 29, 2021
Merged

Re-implement rigid body docking #41

merged 17 commits into from
Jul 29, 2021

Conversation

rvhonorato
Copy link
Member

@rvhonorato rvhonorato commented Jul 26, 2021

This PR re-implements the rigid body docking feature as the rigidbody module in the new architecture. Its cns/ folder contains only the protocols that are needed for it.

@rvhonorato rvhonorato added the enhancement Enhancing an existing feature of adding a new one label Jul 26, 2021
@rvhonorato rvhonorato self-assigned this Jul 26, 2021
@amjjbonvin
Copy link
Member

Probably indeed CNS scripts in this pull - but we can clean later. E.g. build missing is only used when creating the topology / start structures. Should be part of a separate module (e.g. gentop)

@rvhonorato
Copy link
Member Author

Probably indeed CNS scripts in this pull - but we can clean later. E.g. build missing is only used when creating the topology / start structures. Should be part of a separate module (e.g. gentop)

Yes the issue about it is #42 and the topology is already its own module.

@joaomcteixeira
Copy link
Member

Please give me some time to inspect this PR

@joaomcteixeira
Copy link
Member

Just looking very quickly now:
Why are you uploading again the trans_vector_# files if they are already on data/toppar/initial_positions ?

@rvhonorato
Copy link
Member Author

Quick screenshot of a superimposition of 100 models to show that the module is working and using restraints:

Screenshot 2021-07-27 at 13 57 46

@rvhonorato rvhonorato marked this pull request as ready for review July 27, 2021 12:06
@rvhonorato
Copy link
Member Author

rvhonorato commented Jul 27, 2021

Why are you uploading again the trans_vector_# files if they are already on data/toppar/initial_positions ?

These are also CNS scripts, so I copied them to this module's cns/

Comment on lines +137 to +142
# Save module information
io = ModuleIO()
for model in models:
io.add(PDBFile(model))
io.add(expected, "o")
io.save(self.path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block before was inside the for loop. Now it is outside. Is this intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, before it was generating the topology for the models into an assembly, now it does both the models from the assembly and different inputs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is able to continue from a half-run run? If you tested it and it works, perfect.

@joaomcteixeira
Copy link
Member

Following today's conversation, rigidbody/cns has now 98 CNS scripts. Some script names there point to very general purposes, for example the centroids_*.cns family. My question is whether these are really SPECIFIC for rigid body docking, or we can already think of placing them in a module-independent cns dedicated folder.

@amjjbonvin
Copy link
Member

amjjbonvin commented Jul 27, 2021 via email

@joaomcteixeira joaomcteixeira marked this pull request as draft July 27, 2021 16:46
@rvhonorato rvhonorato marked this pull request as ready for review July 27, 2021 17:24
@rvhonorato
Copy link
Member Author

Following today's conversation, rigidbody/cns has now 98 CNS scripts.

45 + translation vectors (approximately). Keep in mind there are nested dependencies, the first level account for ~32

@joaomcteixeira
Copy link
Member

Can't the nested dependencies by pulled from another folder? Maybe via a bridge python file?

@rvhonorato
Copy link
Member Author

Its cns/ folder contains only the protocols that are needed for it.

What I mean with the nested dependencies is that: cns scripts can call another cns scripts that can call another cns script that can call another cns script

@rvhonorato
Copy link
Member Author

Probably best if I take a look - cannot think so many are required just for the rigid body docking

There are not 98, I replied to it in a comment above.

Copy link
Member

@joaomcteixeira joaomcteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvhonorato plase have a look at https://github.com/rvhonorato/haddock3/pull/2 before merging.

As we discussed today, we have a roadmap to change some things here. But if you prefer to merge as it is now and than work on what we discussed with @amjjbonvin, perfect for me.

Comments on `prepare_run` for rigdock
@rvhonorato rvhonorato merged commit 1624426 into haddocking:main Jul 29, 2021
@rvhonorato rvhonorato deleted the rigdock branch July 29, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants