-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement rigid body docking #41
Conversation
Probably indeed CNS scripts in this pull - but we can clean later. E.g. build missing is only used when creating the topology / start structures. Should be part of a separate module (e.g. gentop) |
Yes the issue about it is #42 and the topology is already its own module. |
Please give me some time to inspect this PR |
Just looking very quickly now: |
These are also CNS scripts, so I copied them to this module's |
# Save module information | ||
io = ModuleIO() | ||
for model in models: | ||
io.add(PDBFile(model)) | ||
io.add(expected, "o") | ||
io.save(self.path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block before was inside the for
loop. Now it is outside. Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, before it was generating the topology for the models into an assembly, now it does both the models from the assembly and different inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is able to continue from a half-run run? If you tested it and it works, perfect.
Following today's conversation, |
Probably best if I take a look - cannot think so many are required just for the rigid body docking
|
45 + translation vectors (approximately). Keep in mind there are nested dependencies, the first level account for ~32 |
Can't the nested dependencies by pulled from another folder? Maybe via a bridge python file? |
What I mean with the nested dependencies is that: cns scripts can call another cns scripts that can call another cns script that can call another cns script |
There are not 98, I replied to it in a comment above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvhonorato plase have a look at https://github.com/rvhonorato/haddock3/pull/2 before merging.
As we discussed today, we have a roadmap to change some things here. But if you prefer to merge as it is now and than work on what we discussed with @amjjbonvin, perfect for me.
Comments on `prepare_run` for rigdock
This PR re-implements the rigid body docking feature as the
rigidbody
module in the new architecture. Itscns/
folder contains only the protocols that are needed for it.