Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Ctrl+arrow #11

Closed
hakash opened this issue Oct 4, 2021 · 5 comments · Fixed by #20
Closed

Add support for Ctrl+arrow #11

hakash opened this issue Oct 4, 2021 · 5 comments · Fixed by #20
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@hakash
Copy link
Owner

hakash commented Oct 4, 2021

Add Ctrl+arrow support, aliasing HOME, END, PAGE_UP and PAGE_DOWN
@hakash hakash added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 4, 2021
@Reza9472
Copy link
Contributor

Reza9472 commented Oct 4, 2021

I can work on this issue

@hakash
Copy link
Owner Author

hakash commented Oct 4, 2021

@Reza9472 Go for it 😊

Delhi-Babu added a commit to Delhi-Babu/termit that referenced this issue Oct 5, 2021
@Delhi-Babu
Add Ctrl+arrow support, aliasing HOME, END, PAGE_UP and PAGE_DOWN fixes
69a20ab 
hakash#11
@Delhi-Babu Delhi-Babu mentioned this issue Oct 5, 2021
Closed
@hakash
Copy link
Owner Author

hakash commented Oct 5, 2021

@Reza9472 Another user has submitted a PR on this issue today. You do however have first go, so if you can submit your PR as soon as possible, and no later than a week from now, you will get the PR for Hacktoberfest. If not, I have to award it to the other user. If you feel you can't deliver on this after all, please let me know so I can award it to the other user as soon as possible.

Thank you again for your interest. I am looking forward to seeing your solution. :)

@Reza9472
Copy link
Contributor

Reza9472 commented Oct 5, 2021 •
edited
Loading

Thank you for the message. I will definitely try to submit mine within this week. If I ran into problems, I'll let you know ASAP so you can assign it to someone else.
Thank you

@Reza9472
Copy link
Contributor

Reza9472 commented Oct 5, 2021

Please check my PR and let me know if it needs anything

@Reza9472 Reza9472 mentioned this issue Oct 5, 2021
Merged
@hakash hakash closed this as completed in #20 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@hakash @Reza9472