Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ctrl+arrow support, aliasing HOME, END, PAGE_UP and PAGE_DOWN fixes #11 #18

Closed
wants to merge 1 commit into from

Conversation

Delhi-Babu
Copy link
Contributor

by merging this we fix #11
I mapped based on my laptop's keyboard layout
here is what what does

Key Action
Ctrl+up page_up
Ctrl+down page_down
Ctrl+left home
Ctrl+right end

if needed I can add them on README.md
done for hacktoberfest

@hakash
Copy link
Owner

hakash commented Oct 5, 2021

Thank you for the PR on this issue. However, if you read the comment on the issue another user was assigned this task. I will let the PR hang for now, to see if the other user submits a fix. If not, it is yours. I'll let the other user know about the situation, and I'll give a week. That is well within the two-week grace period mandated by Hacktoberfest, in case the other user does not deliver.

I'm sorry for this, but I have to try to be fair. Hope you understand. Feel free to take a look at the other issues that are up for grabs if you want. They aren't claimed by anyone just yet.

@Delhi-Babu
Copy link
Contributor Author

That is ok, I understand the situation

@hakash
Copy link
Owner

hakash commented Oct 6, 2021

The other user has submitted the PR, so I'm closing this. I'll tag it with hacktoberfest-accepted, and hopefully you will have it count all the same.

@hakash hakash closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Ctrl+arrow
2 participants