Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulkan] Region allocator fixes for memory requirements and allocations #8087

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

derek-gerstmann
Copy link
Contributor

As reported by #8079

  • Add region allocator tests that check alignment, nearest_multiple and collect routines
  • Fix can_split() routine to use conformed sizes so that split allocation matches
  • Fix region size accounting so that coalesce never has zero size regions to merge
  • Fix aligned_offset() routine to check for zero alignment (which means no constraint)
  • Use Vulkan memory_requirements to determine nearest_multiple during initialization
  • Query Vulkan memory_requirements for each region, and reallocate if driver requires additional device memory

Derek Gerstmann added 7 commits February 9, 2024 14:02
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As a nit, there were a lot of superficial changes in debug output that made it harder to parse out the functional changes for review.

@derek-gerstmann
Copy link
Contributor Author

LGTM.

As a nit, there were a lot of superficial changes in debug output that made it harder to parse out the functional changes for review.

Yes, sorry. I tried to isolate the debug formatting stuff to separate commits.

@steven-johnson
Copy link
Contributor

Ready to land?

@derek-gerstmann
Copy link
Contributor Author

Yes, this one is done. There will be more fixes soon.

@derek-gerstmann derek-gerstmann merged commit 9a740b5 into main Feb 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants