-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vulkan] Region allocator fixes for memory requirements and allocations #8087
Conversation
matches Fix region size accounting so that coalesce never has zero size regions to merge
initialization Query memory_requirements for each region, and reallocate if driver requires additional device memory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
As a nit, there were a lot of superficial changes in debug output that made it harder to parse out the functional changes for review.
Yes, sorry. I tried to isolate the debug formatting stuff to separate commits. |
Ready to land? |
Yes, this one is done. There will be more fixes soon. |
As reported by #8079