Handle ARMFp16 and ARMDotProd features in SVE2 #8890
Merged
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SVE2, enable ARMFp16 and ARMDotProd features even if they are not explicitly enabled.
alexreinking
requested changes
Dec 6, 2025
Member
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
I think we should rely rather more on the target than on backend-specific helpers. Keeping the feature-implication logic in one place feels cleaner and clearer to me.
Member
|
I don't know when Github added comments outside the PR diff, but I love it. |
alexreinking
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SVE2, enable
ARMFp16andARMDotProdfeatures even if they are not explicitly enabled.