Handle ARMFp16 and ARMDotProd features in SVE2

src/CodeGen_ARM.cpp

@@ -50,6 +50,12 @@ Target complete_arm_target(Target t) {
         t.set_feature(Target::ARMv84a);
     }
 
+    auto add_implied_feature_if_supported = [](Target &t, Target::Feature super, Target::Feature implied) {
+        if (t.has_feature(super)) {
+            t.set_feature(implied);
+        }
+    };
+
     constexpr int num_arm_v8_features = 10;
     static const Target::Feature arm_v8_features[num_arm_v8_features] = {
         Target::ARMv89a,
@@ -65,9 +71,26 @@ Target complete_arm_target(Target t) {
     };
 
     for (int i = 0; i < num_arm_v8_features - 1; i++) {
-        if (t.has_feature(arm_v8_features[i])) {
-            t.set_feature(arm_v8_features[i + 1]);
-        }
+        add_implied_feature_if_supported(t,
+                                         arm_v8_features[i],
+                                         arm_v8_features[i + 1]);
+    }
+
+    static const Target::Feature features_with_fp16[] = {
+        Target::SVE,
+        Target::SVE2,
+    };
+
+    for (const auto &f : features_with_fp16) {
+        add_implied_feature_if_supported(t, f, Target::ARMFp16);
+    }
+
+    static const Target::Feature features_with_dotprod[] = {
+        Target::SVE2,
+    };
+
+    for (const auto &f : features_with_dotprod) {
+        add_implied_feature_if_supported(t, f, Target::ARMDotProd);
     }
 
     return t;
@@ -1004,7 +1027,7 @@ void CodeGen_ARM::init_module() {
     }
 
     for (const ArmIntrinsic &intrin : intrinsic_defs) {
-        if (intrin.flags & ArmIntrinsic::RequireFp16 && !target.has_feature(Target::ARMFp16)) {
+        if ((intrin.flags & ArmIntrinsic::RequireFp16) && !target.has_feature(Target::ARMFp16)) {
             continue;
         }
 

test/correctness/simd_op_check_sve2.cpp

@@ -1365,7 +1365,7 @@ class SimdOpCheckArmSve : public SimdOpCheckTest {
     };
 
     bool is_float16_supported() const {
-        return (target.bits == 64) && target.has_feature(Target::ARMFp16);
+        return (target.bits == 64) && target.features_any_of({Target::ARMFp16, Target::SVE, Target::SVE2});
     }
 
     bool can_run_the_code;

test/warning/emulated_float16.cpp

@@ -12,7 +12,7 @@ int main(int argc, char **argv) {
 
     // Make sure target has no float16 native support
     Target t = get_host_target();
-    for (auto &feature : {Target::F16C, Target::ARMFp16}) {
+    for (auto &feature : {Target::F16C, Target::ARMFp16, Target::SVE, Target::SVE2}) {
         t = t.without_feature(feature);
     }