Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies (submodules) so that the project builds on Linux ARM64 #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependencies (submodules) so that the project builds on Linux ARM64 #150

wants to merge 1 commit into from

Conversation

martin-g
Copy link

Add Github Actions based CI. It builds and tests on Linux x86_64 and aarch64

@martin-g
Update dependencies (submodules) so that the project builds on Linux …
b7cd789 
…ARM64

Add Github Actions based CI. It builds and tests on Linux x86_64 and aarch64

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Author

Fixes #149

@martin-g martin-g mentioned this pull request Oct 18, 2022
Merged
@martin-g
Copy link
Author

martin-g commented Nov 8, 2022

Any feedback on the proposed changes ?
Without these changes it is impossible to use speedseq on ARM64 due to the usage of x86_64 binary for Sambamba.
This PS uses Sambamba as a submodule and builds it for the current CPU architecture.
Also this PR updates Bwa to a newer version that supports ARM64.

@emiliofernandes
Copy link

I also needed to build speedseq on Linux ARM64!
Thank you, @martin-g !
I hope this PR is merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-g @emiliofernandes