Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

在 Console 端回复评论需要审核 #3353

Closed
ruibaby opened this issue Feb 21, 2023 · 2 comments · Fixed by #3363
Closed

在 Console 端回复评论需要审核 #3353

ruibaby opened this issue Feb 21, 2023 · 2 comments · Fixed by #3363
Assignees
@guqing
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.3.0

Comments

@ruibaby
Copy link
Member

ruibaby commented Feb 21, 2023

是什么版本出现了此问题？

2.2.1

使用的什么数据库？

PostgreSQL

使用的哪种方式部署？

Docker

在线站点地址

https://ryanc.cc

发生了什么？

image

如图，在 Console 端回复评论之后需要进行审核，建议改为不需要。

/area console
/kind improvement
/milestone 2.3.x

相关日志输出

No response

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Feb 21, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.x milestone Feb 21, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Feb 21, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Feb 21, 2023

/remove-area console
/area core

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core and removed area/console Issues or PRs related to the Halo Console labels Feb 21, 2023
@guqing
Copy link
Member

guqing commented Feb 22, 2023

/assign

@guqing guqing mentioned this issue Feb 22, 2023
Merged
JohnNiang pushed a commit that referenced this issue Feb 24, 2023
@guqing
refactor: default is approved to reply to comments on the console-side (
adff2a7 
#3363)

#### What type of PR is this?
/kind improvement
/area core
/milestone 2.3.x

#### What this PR does / why we need it:
Console 端创建回复不再需要审核
但需要注意的是目前无法区分是否为管理员，所以如果具有评论管理权限的用户在主题端登录回复还是需要审核。

#### Which issue(s) this PR fixes:
Fixes #3353

#### Special notes for your reviewer:
how to test it?
1. 在主题端创建评论和回复都需要审核
2. 在 console 端回复不需要审核

/cc @halo-dev/sig-halo 
#### Does this PR introduce a user-facing change?

```release-note
Console 端创建回复不再需要审核
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

refactor: default is approved to reply to comments on the console-side guqing/halo
2 participants
@ruibaby @guqing