-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: default is approved to reply to comments on the console-side #3363
Conversation
@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo. Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO,我们可以提供两个接口用于评论回复,一个需要审核,一个不需要审核。我们在配置权限规则的时候区分一下。例如:管理员角色中包含“不需要审核评论接口”规则,普通用户角色中只包含“需要审核评论接口”。
但是并不能解决管理员在主题端回复还是需要审核的问题吧 这个只能后台用户哪些需要审核和不需要审核的问题,主题端回复的 api 是无法判断权限的 |
# Conflicts: # src/main/java/run/halo/app/content/comment/ReplyServiceImpl.java
Hi @guqing,需要解决一下冲突。 |
Done |
Codecov Report
@@ Coverage Diff @@
## main #3363 +/- ##
============================================
- Coverage 60.11% 60.10% -0.01%
- Complexity 2390 2391 +1
============================================
Files 388 388
Lines 12328 12330 +2
Branches 987 989 +2
============================================
Hits 7411 7411
- Misses 4447 4449 +2
Partials 470 470
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.3.x
What this PR does / why we need it:
Console 端创建回复不再需要审核
但需要注意的是目前无法区分是否为管理员,所以如果具有评论管理权限的用户在主题端登录回复还是需要审核。
Which issue(s) this PR fixes:
Fixes #3353
Special notes for your reviewer:
how to test it?
/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?