Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: disable syncAllOnStart for tag reconciler #3316

Merged
merged 2 commits into from
Feb 15, 2023
Merged

perf: disable syncAllOnStart for tag reconciler #3316

merged 2 commits into from
Feb 15, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 15, 2023 •
edited by JohnNiang
Loading

What type of PR is this?

/kind improvement

What this PR does / why we need it:

暂时禁用 Tag Reconciler 在启动的时候同步。（临时解决方案）

Which issue(s) this PR fixes:

Fixes #3312

Does this PR introduce a user-facing change?

禁用系统启动时同步标签文章数的功能

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 15, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and LIlGG February 15, 2023 09:04
@ruibaby
Copy link
Member Author

ruibaby commented Feb 15, 2023

/cheery-pick release-2.2

@ruibaby
Copy link
Member Author

ruibaby commented Feb 15, 2023

/cherry-pick release-2.2

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby added this to the 2.3.x milestone Feb 15, 2023
JohnNiang
JohnNiang approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
guqing
guqing reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@LIlGG
Copy link
Member

LIlGG commented Feb 15, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot merged commit dd161ee into halo-dev:main Feb 15, 2023
@ruibaby ruibaby deleted the perf/disable-sync-all-on-start branch February 15, 2023 10:16
@halo-dev-bot halo-dev-bot mentioned this pull request Feb 15, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #3318

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 15, 2023
@halo-dev-bot
[release-2.2] perf: disable syncAllOnStart for tag reconciler (#3318)
3ae174c 
This is an automated cherry-pick of #3316

/assign ruibaby

```release-note
禁用系统启动时同步标签文章数的功能
```
@guqing guqing mentioned this pull request Feb 15, 2023
Closed
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 15, 2023
@guqing
fix: route for the tag is not registered when halo starts (#3322)
3cde340 
#### What type of PR is this?
/kind bug
/area core
/milestone 2.3.x

#### What this PR does / why we need it:
1. 去掉原 TagReconciler 的 requeue 逻辑，来临时解决大量 tag 时 reconciler 空转导致 cpu 下不来的问题，参考： #3311
2. 增加 TagRouteReconciler 在启动时注册路由

#### Which issue(s) this PR fixes:
Fixes #3321

#### Special notes for your reviewer:
/cc @halo-dev/sig-halo 
#### Does this PR introduce a user-facing change?
```release-note
修复 #3316 引入的 tags 标签的路由没有注册的问题
```
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 15, 2023
@halo-dev-bot
[release-2.2] fix: route for the tag is not registered when halo star…
a227341 
…ts (#3323)

This is an automated cherry-pick of #3322

/assign guqing

```release-note
修复 #3316 引入的 tags 标签的路由没有注册的问题
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@LIlGG LIlGG

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

标签过多时 TagReconciler 耗时很长
5 participants
@ruibaby @halo-dev-bot @LIlGG @JohnNiang @guqing