Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: route for the tag is not registered when halo starts #3322

Merged
merged 2 commits into from
Feb 15, 2023
Merged

fix: route for the tag is not registered when halo starts #3322

merged 2 commits into from
Feb 15, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 15, 2023

What type of PR is this?

/kind bug
/area core
/milestone 2.3.x

What this PR does / why we need it:

  1. 去掉原 TagReconciler 的 requeue 逻辑，来临时解决大量 tag 时 reconciler 空转导致 cpu 下不来的问题，参考： 文章取消引用标签后相应标签的文章数量没有更新 #3311
  2. 增加 TagRouteReconciler 在启动时注册路由

Which issue(s) this PR fixes:

Fixes #3321

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

修复 #3316 引入的 tags 标签的路由没有注册的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 15, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.x milestone Feb 15, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 15, 2023

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo.

Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind bug
/area core
/milestone 2.3.x

What this PR does / why we need it:

  1. 去掉原 TagReconciler 的 requeue 逻辑，来临时解决大量 tag 时 reconciler 空转导致 cpu 下不来的问题，参考： 文章取消引用标签后相应标签的文章数量没有更新 #3311
  2. 增加 TagRouteReconciler 在启动时注册路由

Which issue(s) this PR fixes:

Fixes #3321

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

修复 #3316 引入的 tags 标签的路由没有注册的问题

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 15, 2023
@guqing
Copy link
Member Author

guqing commented Feb 15, 2023

/cherry-pick release-2.2

@halo-dev-bot
Copy link
Collaborator

@guqing: once the present PR merges, I will cherry-pick it on top of release-2.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing
Copy link
Member Author

guqing commented Feb 15, 2023

/cc @halo-dev/sig-halo

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 15, 2023

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo.

Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @halo-dev/sig-halo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ruibaby
ruibaby reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
guqing
guqing commented Feb 15, 2023
View reviewed changes
src/main/java/run/halo/app/core/extension/reconciler/TagRouteReconciler.java
client.fetch(Tag.class, request.name())
.ifPresent(tag -> {
if (tag.getMetadata().getDeletionTimestamp() != null) {
// TagReconciler already did it, so there is no need to remove permalink
Copy link
Member Author

@guqing guqing Feb 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注： 这里不再删除路由，这个逻辑在 TagReconciler 已经做了就不在修改，因为此 Reconciler 没有添加 Finalizer 如果在这里做可能不可靠

@guqing guqing requested a review from JohnNiang February 15, 2023 13:50
JohnNiang
JohnNiang approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 3cde340 into halo-dev:main Feb 15, 2023
@guqing guqing deleted the fix/3321 branch February 15, 2023 13:52
@halo-dev-bot halo-dev-bot mentioned this pull request Feb 15, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@guqing: new pull request created: #3323

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 15, 2023
@halo-dev-bot
[release-2.2] fix: route for the tag is not registered when halo star…
a227341 
…ts (#3323)

This is an automated cherry-pick of #3322

/assign guqing

```release-note
修复 #3316 引入的 tags 标签的路由没有注册的问题
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

2.2.1 tags 标签的路由没有注册
4 participants
@guqing @halo-dev-bot @JohnNiang @ruibaby