Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct file mime type validation parameter to restore functionality #6673

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 18, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

修复文件上传时类型校验失效的问题

此问题由 #6390 导致

Does this PR introduce a user-facing change?

修复文件上传时类型校验失效的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG September 18, 2024 08:14
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.14%. Comparing base (6cd8dc8) to head (9533d35).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
...achment/endpoint/LocalAttachmentUploadHandler.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6673      +/-   ##
============================================
- Coverage     58.18%   58.14%   -0.04%     
- Complexity     3774     3942     +168     
============================================
  Files           651      679      +28     
  Lines         22125    23216    +1091     
  Branches       1538     1582      +44     
============================================
+ Hits          12873    13500     +627     
- Misses         8641     9092     +451     
- Partials        611      624      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@guqing
Copy link
Member Author

guqing commented Sep 23, 2024

/ping @halo-dev/sig-halo

@JohnNiang
Copy link
Member

另外,有冲突需要解决。

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2024
@f2c-ci-robot f2c-ci-robot bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 24, 2024
Copy link

@guqing guqing requested a review from JohnNiang September 25, 2024 02:52
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
Copy link

f2c-ci-robot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f6409a0 into halo-dev:main Sep 25, 2024
8 checks passed
@guqing guqing deleted the fix/mime-validation branch September 25, 2024 03:00
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants