-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ReactivePropertyAccessor by wrapping existing PropertyAccessor #6686
Refactor ReactivePropertyAccessor by wrapping existing PropertyAccessor #6686
Conversation
Signed-off-by: JohnNiang <johnniang@foxmail.com>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6686 +/- ##
============================================
- Coverage 58.18% 58.17% -0.02%
- Complexity 3774 3944 +170
============================================
Files 651 679 +28
Lines 22125 23216 +1091
Branches 1538 1582 +44
============================================
+ Hits 12873 13505 +632
- Misses 8641 9087 +446
- Partials 611 624 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/area theme
What this PR does / why we need it:
This PR removes ReactivePropertyAccessor because it use
AstUtils#getPropertyAccessorsToTry
which is already hidden in the commit. If we upgraded to Spring Boot 3.4.0-M3, the code in ReactivePropertyAccessor would be broken.More importantly, I believe there is one issue with the current implementation although it can resolve the reactive issue.
This PR provides some wrappers to wrap existing PropertyAccessor and MethodResolver to evaluate reactive return value.
Does this PR introduce a user-facing change?