Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ReactivePropertyAccessor by wrapping existing PropertyAccessor #6686

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/area theme

What this PR does / why we need it:

This PR removes ReactivePropertyAccessor because it use AstUtils#getPropertyAccessorsToTry which is already hidden in the commit. If we upgraded to Spring Boot 3.4.0-M3, the code in ReactivePropertyAccessor would be broken.

More importantly, I believe there is one issue with the current implementation although it can resolve the reactive issue.

  • The PropertyAccessor modified the process flow of SPEL

This PR provides some wrappers to wrap existing PropertyAccessor and MethodResolver to evaluate reactive return value.

Does this PR introduce a user-facing change?

None

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby September 22, 2024 15:29
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/theme Issues or PRs related to the Theme Provider labels Sep 22, 2024
Copy link

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 87.35632% with 11 lines in your changes missing coverage. Please review.

Project coverage is 58.17%. Comparing base (6cd8dc8) to head (04f3aef).
Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
...o/app/theme/dialect/EvaluationContextEnhancer.java 86.15% 4 Missing and 5 partials ⚠️
...n/java/run/halo/app/infra/utils/ReactiveUtils.java 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6686      +/-   ##
============================================
- Coverage     58.18%   58.17%   -0.02%     
- Complexity     3774     3944     +170     
============================================
  Files           651      679      +28     
  Lines         22125    23216    +1091     
  Branches       1538     1582      +44     
============================================
+ Hits          12873    13505     +632     
- Misses         8641     9087     +446     
- Partials        611      624      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang JohnNiang added this to the 2.20.x milestone Sep 22, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
Copy link

f2c-ci-robot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 8b3bde0 into halo-dev:main Sep 23, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/theme Issues or PRs related to the Theme Provider kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants