Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring Boot 3.4.0-M3 #6687

Merged

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Sep 22, 2024

What type of PR is this?

/kind cleanup
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR upgrades to Spring Boot 3.4.0-M3.

  1. Fix the compilation error of OptimalPropertyAccess because the class has been privated in this commit.
  2. Fix exception org.mockito.exceptions.misusing.UnnecessaryStubbingException for some unit tests after upgrading.
  3. Replace deprecated annotations @MockBean and @SpyBean with @MockitoBean and @MockitoSpyBean respectively.

Does this PR introduce a user-facing change?

升级 Spring Boot 至 3.4.0-M3

@f2c-ci-robot f2c-ci-robot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 22, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen September 22, 2024 15:33
@JohnNiang
Copy link
Member Author

Wait for #6686 to be merged.

@guqing
Copy link
Member

guqing commented Sep 23, 2024

编译没过 需要修复一下

@JohnNiang JohnNiang force-pushed the chore/upgrade-to-springboot-3.4.0-M3 branch 2 times, most recently from 4711130 to 547c7d1 Compare September 23, 2024 13:45
@JohnNiang
Copy link
Member Author

编译没过 需要修复一下

编译错误和单元测试错误已经修复。

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.18%. Comparing base (6cd8dc8) to head (8afab2e).
Report is 84 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##               main    #6687     +/-   ##
===========================================
  Coverage     58.18%   58.18%             
- Complexity     3774     3944    +170     
===========================================
  Files           651      679     +28     
  Lines         22125    23216   +1091     
  Branches       1538     1582     +44     
===========================================
+ Hits          12873    13508    +635     
- Misses         8641     9084    +443     
- Partials        611      624     +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@JohnNiang JohnNiang force-pushed the chore/upgrade-to-springboot-3.4.0-M3 branch from 547c7d1 to 8afab2e Compare September 23, 2024 13:56
Copy link

@JohnNiang
Copy link
Member Author

/ping @halo-dev/sig-halo

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
Copy link

f2c-ci-robot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 86b95cc into halo-dev:main Sep 24, 2024
8 checks passed
@JohnNiang JohnNiang deleted the chore/upgrade-to-springboot-3.4.0-M3 branch September 24, 2024 08:25
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants