Use new public API from rom-repository #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I deprecated Repository#set_relation, it was a private API. It didn't set anything so the name was confusing. I added #prepare_relation and made it public as well. This replaces the call and updates the dependencies.
|
Thanks for fixing this so quickly! LGTM, fixes all the deprecation warnings in my app. Will let @timriley merge so he can do a patch release as well |
|
Thanks for this! It looks good. I'm going to leave this open until I can do a patch release. I'll try to do it tonight. |
|
Merged and released as 2.2.1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deprecated
Repository#set_relation, it was a private API. It didn't set anything so the name was confusing. I added#prepare_relationand made it public as well. This replaces the call and updates the dependencies.